Skip to content

Fix PhotonLoss input conventions#167

Open
sansiro77 wants to merge 1 commit into
TuringQ:mainfrom
sansiro77:codex/issue-161-loss-db-autograd
Open

Fix PhotonLoss input conventions#167
sansiro77 wants to merge 1 commit into
TuringQ:mainfrom
sansiro77:codex/issue-161-loss-db-autograd

Conversation

@sansiro77

Copy link
Copy Markdown
Contributor

Summary

  • add a convention option to PhotonLoss for theta, transmittance, and dB inputs
  • keep PhotonLoss internally parameterized by theta
  • make loss_t(..., encode=True) and loss_db(..., encode=True) consume encoded data as transmittance / dB
  • warn when a leaf trainable tensor is passed to loss_t / loss_db through inputs

Addresses #161.

@sansiro77 sansiro77 requested a review from Jooyuza June 17, 2026 09:06
@sansiro77 sansiro77 self-assigned this Jun 17, 2026
@sansiro77 sansiro77 added the bugfix Fix bugs label Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Fix bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

loss_db(inputs=param) /loss_t stores a stale autograd graph in cached circuits

1 participant